Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2072): enable applitools logs #186

Merged
merged 2 commits into from
May 4, 2022
Merged

feat(PPDSC-2072): enable applitools logs #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9709c2d
feat(PPDSC-2072): enable applitools logs
tbradbury May 3, 2022
a1a13a4
Merge branch 'main' into feat/PPDSC-2072-enable-logs
tbradbury May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"dev": "concurrently --names \"src,storybook,docs\" \"yarn build:ts --watch\" \"yarn dev:storybook\" \"next site -p 8081\"",
"dev:docs": "yarn build:icons:dev && concurrently --names \"src,docs\" \"yarn build:ts --watch\" \"next site -p 8081\"",
"dev:storybook": "yarn build:icons:dev && start-storybook --ci -p 6006 -s ./fonts,./static",
"eyes:storybook": "eyes-storybook --conf applitools.components.config.js",
"eyes:storybook": "APPLITOOLS_SHOW_LOGS=true eyes-storybook --conf applitools.components.config.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set in the config? Does this override the config setting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add it in the config the Batched get split up

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

"lint:code:base": "eslint --report-unused-disable-directives --ext=.js,.ts,.jsx,.tsx --cache",
"lint:code": "scripts/assert-files-and-folders.js && yarn lint:code:base .",
"lint:code:fix": "yarn lint:code --fix",
Expand Down Expand Up @@ -55,7 +55,7 @@
"e2e:docs": "cypress open --config-file cypress/config/cypress.docs.json",
"e2e:comps:ci": "start-server-and-test e2e:serve 8080 'TZ=UTC cypress run --config-file cypress/config/cypress.components.json'",
"e2e:docs:ci": "start-server-and-test serve:docs 8081 'TZ=UTC cypress run --config-file cypress/config/cypress.docs.json'",
"e2e:visual:docs:ci": "start-server-and-test serve:docs 8081 'TZ=UTC cypress run --config-file cypress/config/cypress.docs.visual.json'",
"e2e:visual:docs:ci": "start-server-and-test serve:docs 8081 'TZ=UTC APPLITOOLS_SHOW_LOGS=true cypress run --config-file cypress/config/cypress.docs.visual.json'",
"e2e:generate:a11ytests": "node scripts/generate-a11y-tests.js",
"e2e:findbrokenlinks": "linkinator http://localhost:8081 --recurse --skip '^(?!http://localhost:8081)'",
"e2e:findbrokenlinks:ci": "start-server-and-test serve:docs 8081 e2e:findbrokenlinks",
Expand All @@ -66,8 +66,8 @@
"storybook": "start-storybook -c .storybook -p 6006 -s ./fonts,./static"
},
"devDependencies": {
"@applitools/eyes-cypress": "^3.23.3",
"@applitools/eyes-storybook": "^3.27.4",
"@applitools/eyes-cypress": "^3.25.6",
"@applitools/eyes-storybook": "^3.27.6",
"@babel/core": "^7.13.15",
"@babel/parser": "^7.14.6",
"@commitlint/cli": "^8.0.0",
Expand Down
Loading