feat(PPDSC-2072): enable applitools logs #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbradbury
requested review from
jps,
Xin00163,
pdimova,
baburay23,
mutebg,
Vanals,
evgenitsn and
Srinivasan-Ramasamy
as code owners
|
You can preview these changes on: |
Xin00163
reviewed
May 3, 2022
| @@ -18,7 +18,7 @@ | |||
| "dev": "concurrently --names \"src,storybook,docs\" \"yarn build:ts --watch\" \"yarn dev:storybook\" \"next site -p 8081\"", | |||
| "dev:docs": "yarn build:icons:dev && concurrently --names \"src,docs\" \"yarn build:ts --watch\" \"next site -p 8081\"", | |||
| "dev:storybook": "yarn build:icons:dev && start-storybook --ci -p 6006 -s ./fonts,./static", | |||
| "eyes:storybook": "eyes-storybook --conf applitools.components.config.js", | |||
| "eyes:storybook": "APPLITOOLS_SHOW_LOGS=true eyes-storybook --conf applitools.components.config.js", | |||
There was a problem hiding this comment.
Why not set in the config? Does this override the config setting?
There was a problem hiding this comment.
If you add it in the config the Batched get split up
Xin00163
approved these changes
May 4, 2022
baburay23
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2072
What
To enable quicker debugging of issue in Applitools this enables the log flag so we get extra information if the CircleCi console. This can then be downloaded and sent to Applitools.
2. Enables the Applitools log flag. I also update the Applitools packages
3. Extra log information inside the CicrleCi console for the jobs.
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: