-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: addition of client code corresponding to packages customeradministration, authorizationmanagement, organization #1126
Conversation
…nistration package
…eAsyncResults nested query
a614465
to
804f7bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1126 +/- ##
==========================================
- Coverage 38.84% 37.82% -1.03%
==========================================
Files 86 92 +6
Lines 5612 6044 +432
==========================================
+ Hits 2180 2286 +106
- Misses 3266 3589 +323
- Partials 166 169 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Type | Path in NerdGraph |
---|---|
MultiTenantAuthorizationGrantAuthenticationDomainIdInputFilter | customerAdministration > grants > filter! > authenticationDomainId |
MultiTenantAuthorizationGrantGroupIdInputFilter | customerAdministration > grants > filter! > groupId |
MultiTenantAuthorizationGrantScopeIdInputFilter | customerAdministration > grants > filter! > scopeId |
MultiTenantAuthorizationRoleGroupIdInputFilter | customerAdministration > roles > filter! > groupId |
MultiTenantIdentityUserGroupIdInput | customerAdministration > users > filter! > groupId |
MultiTenantIdentityUserIdInput | ~ |
OrganizationOrganizationCreateJobIdInput | customerAdministration > jobs > organizationCreateAsyncResults > filter! > jobId |
UserManagementGroupIdInput | ~ |
UserManagementUserIdInput | ~ |
Background
A new package,
customeradministration
was recently added to NerdGraph (few months ago), after which significant customer interests were received to have these under the purview of the New Relic Go Client, in order to be able to perform these queries in Go. This was conveyed to the team maintaining the Go Client (New Relic Internal: see this Jira ticket for more details), as a result of which work was logged to have the package added to the client.In addition to the above, further interests were received in terms of PR contributions, in order to have a few mutations from the
authorizationmanagement
andorganization
packages also included in addition tocustomeradministration
, in order to enable a few additional functions for customers via the Go Client (to manage organizations, grants, and more).This PR is a consolidation of all of the above -
customeradministration
package on NerdGraph to perform queriesauthorizationmanagement
andorganization
to manage grants and organizationsTests
Tests have been added to all relevant code changes, however, a few of these endpoints added have been excluded (owing to reasons listed here - New Relic Internal), to be added as a follow up to this PR after necessary evalutation.
Things to Note
This PR also proposes the addition of two new secrets,
INTEGRATION_TESTING_NEW_RELIC_ORGANIZATION_ID
andINTEGRATION_TESTING_NEW_RELIC_AUTHENTICATION_DOMAIN_ID
as it might not be a good idea to have these included in the code. These secrets have been added to this repository, and require to be added to local environment in order to test most test cases written in this PR.