Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(customeradministration): Add customeradministration and jobs pkgs. #1109

Closed
wants to merge 3 commits into from

Conversation

kporras07
Copy link
Contributor

This is 2/2 PRs coming from consolidating the following PRs as advised: #1097 #1098 #1099 #1100

I made job a package inside customeradministration to get tutone to do the right thing with types, otherwise it was acting super weird and referencing types like customeradministration.Job.OrganizationCreateResults which would obviously not work

// An organization create job id
Eq string `json:"eq,omitempty"`
// A set of job ids to search for
In []string `json:"in"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any guidance on how to get omitempty here via tutone? This is making the query fail

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately is not supported by Tutone - and you're right, I find that the query fails when there is Eq with omitempty and In without an omitempty - experienced this a few days ago. We certainly can manually change this to omitempty in the code, but that would lead to a lot of manual overrides, which would lead to confusion when this package is Tutone generated sometime later.

While I try finding a solution to this, I think the only way for now would be to use In instead of Eq (add the string to be queried to a list, and supply it to In)

@pranav-new-relic
Copy link
Member

pranav-new-relic commented Apr 15, 2024

Hi @kporras07, thank you so much for the contribution. In order to draw distinctive lines between endpoints present in
different packages on NerdGraph, we went ahead and created another PR #1126 (a combination of your changes in #1108 and #1109, and more), which has just been merged.

In the merged code,

  • The customeradministration package includes the endpoint to fetch the async status of jobs and fetch the organization (along with all other endpoints, but I'm listing only these out as I believe these are what you need over the rest).
  • The authorizationmanagement package includes mutations to grant and revoke roles to groups/accounts.
  • The organization package includes mutations to create and update organizations.

It will take us a while until we release these changes, so please feel free to test these out. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants