RFC: make Dataset._setup_host_cell_index explicitly thread-safe
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
tst/thread_safety
branch
from
ade87e7 to
5f90168
Compare
neutrinoceros
force-pushed
the
tst/thread_safety
branch
from
5f90168 to
1b31bb2
Compare
neutrinoceros
force-pushed
the
tst/thread_safety
branch
2 times, most recently
from
beec4fe to
8dff414
Compare
neutrinoceros
force-pushed
the
tst/thread_safety
branch
from
8dff414 to
fac384c
Compare
neutrinoceros
changed the title
Dataset._setup_host_cell_index explicitly thread-safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local testing seems to indicate that the function is de-facto sort-of thread-safe already because of its fast path mechanism, but I want to start checking for it systematically and maybe make the implementation explicitly thread-aware.