-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: test CPython 3.13 (free-threading flavor) #198
Conversation
I thought numpy dev would build easily already, but maybe I'm doing something wrong. Will re-assess in a couple weeks to months. |
e466454
to
4914d1b
Compare
e16a73e
to
91ab21a
Compare
numpy now builds nightly wheels for both 3.13 and 3.13t, but Cython generation is currently failing |
91ab21a
to
251290a
Compare
5349df1
to
a4d7959
Compare
Building works but I really wasn't expecting tests to pass too. I need to better understand what's going on before I can confidently merge this. |
0bfb67e
to
18e65a1
Compare
@@ -1,3 +1,5 @@ | |||
# cython: freethreading_compatible = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This macro is not documented yet, so I'll wait until cython/cython#6298 is merged before I can call it stable enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's documented in https://cython.readthedocs.io/en/latest/src/userguide/source_files_and_compilation.html#compiler-directives already.
(With that said, you should the official line is that everything free-threaded is experimental for the foreseeable future and may change as needed. But that particular directive is probably fairly unlikely to change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I missed that ! And dully noted, all of this is still experimental, I'm just experimenting along :)
I think the reason why tests pass already is that all loops run in single threads (i.e., I use |
I understand now that I need to exercise multi-threading in CI for this to have value beyond just knowing that gpgi builds in 3.13t. I got started on that in #233 |
6661b07
to
c208b5d
Compare
c208b5d
to
86918ad
Compare
No description provided.