Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-272 - NETOBSERV-274 - Query protocols & stats, port names #126

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Apr 20, 2022

Linked to formatPort & formatProtocol from utils

@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jpinsonneau after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau requested review from jotak and mariomac April 20, 2022 13:51
@mariomac
Copy link

I see that protocols now have a name, but for ports, I still see them in numbers even for well-known ports:
image
BTW, I'd also sort the ports numerically instead of alphabetically (maybe to be done in another PR).

@jpinsonneau
Copy link
Contributor Author

jpinsonneau commented Apr 25, 2022

I see that protocols now have a name, but for ports, I still see them in numbers even for well-known ports

Did you correctly set your frontendConfig ?
netobserv/network-observability-operator#71 & #102

Edit: it's not working on OKD 😨 but ok on OpenShift
image
It's not related to that PR since I'm only using existing utils.

BTW, I'd also sort the ports numerically instead of alphabetically (maybe to be done in another PR).

I can do this in the same PR 👍 thanks

@openshift-ci openshift-ci bot added the lgtm label Apr 25, 2022
@jpinsonneau jpinsonneau merged commit 954f84f into netobserv:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants