-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add package for pull request and comment #2693
Conversation
It requires an extra action to sign a package, what if sign packages when the PR author is permitted, as we did in add-replied-label(https://github.com/nervosnetwork/neuron/blob/develop/.github/workflows/add-replied-label.yml#L13-L29) |
The original intention is to skip |
From the GitHub action document, because most of the PR is opened by the forked repository, the action cannot read other secrets. But for every push event, it will sign with certificates. it's enough to sign on Developers can get the signed package when they push codes to their repository if they have certificates. |
If I forked Neuron to If |
It will try to sign but will fail. I want to keep uniform rules, then every pr comment package will be unsigned, and if a commit comment exists it will be a signed package. For the original intention, I will change the GitHub action, to skip code sign when certificates are missing. |
eacdc13
to
184bd70
Compare
|
80fb9e4
to
a162a29
Compare
1e2f1d7
to
6e9783c
Compare
…ull_request, comment on the pr.
Because the trigger on
workflow_run
needs the action's yml file to exist on the default branch.yanguoyu#38 (comment) is an example of a comment package for committing to PR.
Package Neuron for Test
action