-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow packaging without certificates #154
Comments
Vote up for option 4, I also suggest that we should only sign when releasing, not every |
I think Checksums in the release note can be used to distinguish |
https://github.com/nervosnetwork/neuron/actions/runs/5251984962 |
Try these steps:
|
CI blames about the permission at https://github.com/nervosnetwork/neuron/actions/runs/5347657156/jobs/9696452185?pr=2740#step:10:173 |
This suggestion is from nervosnetwork/neuron#2674 (comment)
PRs come from other repo will not package apps because the certificates for package is only accessible inside nervosnetwork/neuron.
But PRs from other contributors are welcome, and allowing packaging for test facilitates verification.
So we may update the workflow of https://github.com/nervosnetwork/neuron/blob/develop/.github/workflows/package_for_test.yml to make it available without certificates.
Following are the ideas proposed in the original comment
I think option 4 is more reasonable because
package for macos
is necessary during verification, so it can not be skipped.Any idea from contributors? @WhiteMinds @yanguoyu @JeffreyMa597 @devchenyan @homura @zhangyouxin @IronLu233
The text was updated successfully, but these errors were encountered: