Remote storage metrics follow-up #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
requested review from
shanyp and
LizardWizzard
and removed request for
a team
2 tasks
koivunej
changed the title
1588 tests run: 1511 passed, 0 failed, 77 skipped (full report)The comment gets automatically updated with the latest test results
80515b3 at 2023-08-14T11:38:22.462Z :recycle: |
arpad-m
requested changes
Aug 10, 2023
Co-authored-by: Arpad Müller <[email protected]>
koivunej
commented
Aug 11, 2023
arpad-m
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4942 left old metrics in place for migration purposes. It was noticed that from new metrics the total number of deleted objects was forgotten, add it.
While reviewing, it was noticed that the delete_object could just be delete_objects of one.