Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote_storage metrics: remove deprecated, migrate dashboards #4942

Closed
1 of 2 tasks
koivunej opened this issue Aug 9, 2023 · 2 comments
Closed
1 of 2 tasks

remote_storage metrics: remove deprecated, migrate dashboards #4942

koivunej opened this issue Aug 9, 2023 · 2 comments
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver

Comments

@koivunej
Copy link
Member

koivunej commented Aug 9, 2023 •
edited
Loading

Follow-up to #4892, from PR desc:

Removal and migration instructions:

neon/libs/remote_storage/src/s3_bucket/metrics.rs

Lines 128 to 133 in 4ce7aa9

/// Total requests attempted
// TODO: remove after next release and migrate dashboards to `sum by (result) (remote_storage_s3_requests_count)`
requests: RequestTyped<IntCounter>,
/// Subset of attempted requests failed
// TODO: remove after next release and migrate dashboards to `remote_storage_s3_requests_count{result="err"}`
failed: RequestTyped<IntCounter>,

sum by (result) (remote_storage_s3_requests_count)

This migration suggestion is wrong; the old one included all (succeeded, failed, cancelled) requests, so it would just be sum over all remote_storage_s3_requests_count per instance or whatever we want to filter for.
@koivunej koivunej added c/storage/pageserver Component: storage: pageserver c/storage/s3 a/tech_debt Area: related to tech debt m/good_first_issue Moment: when doing your first Neon contributions labels Aug 9, 2023
@koivunej koivunej changed the title remote_storage metrics follow-up, remove deprecated, migrate dashboards remote_storage metrics: remove deprecated, migrate dashboards Aug 9, 2023
@koivunej koivunej mentioned this issue Aug 10, 2023
Merged
@koivunej koivunej removed the m/good_first_issue Moment: when doing your first Neon contributions label Aug 10, 2023
koivunej added a commit that referenced this issue Aug 15, 2023
@koivunej @arpad-m
Remote storage metrics follow-up (#4957)
8198b86 
#4942 left old metrics in place for migration purposes. It was noticed
that from new metrics the total number of deleted objects was forgotten,
add it.

While reviewing, it was noticed that the delete_object could just be
delete_objects of one.

---------

Co-authored-by: Arpad Müller <[email protected]>
@jcsp
Copy link
Contributor

jcsp commented Mar 28, 2024

@koivunej is this issue still relevant?

@jcsp jcsp removed the c/storage/s3 label Jun 17, 2024
@koivunej
Copy link
Member Author

Probably not, the new dashy has been in use for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcsp @koivunej