Fix flakiness of test_metric_collection #4346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Test
test_metric_collection
become flaky (an example):I suspect it is caused by having 2 places when we define
httpserver_listen_address
fixture (which is internally used bypytest-httpserver
plugin)Summary of changes
httpserver_listen_address
fromtest_runner/regress/test_ddl_forwarding.py
and keep one intest_runner/fixtures/neon_fixtures.py
httpserver_listen_address
parameter fromtest_proxy_metric_collection
Checklist before requesting a review
Checklist before merging