test_metric_collection is flaky

[koivunej]

Unlike previous #3186 now we have an assertion like:

test_runner/regress/test_metric_collection.py:167: in test_metric_collection
    assert len(metric_kinds_checked) == len(
E   AssertionError: Expected to receive and check all kind of metrics, but {'written_size', 'remote_storage_size', 'resident_size', 'timeline_logical_size'} got uncovered
E   assert 0 == 4
E    +  where 0 = len(set())
E    +  and   4 = len({'remote_storage_size': <function <lambda> at 0x7fa57e584b80>, 'resident_size': <function <lambda> at 0x7fa57e584af0>, 'timeline_logical_size': <function <lambda> at 0x7fa57e584c10>, 'written_size': <function <lambda> at 0x7fa57e584a60>})

I guess is that means that we never upload those metrics. Previous issue had only written_size.

Example allure report with failures:

• pg14 + noop
• pg15 + noop
• pg15 + local_fs

I feel like we've seen this more broadly than the above.

[koivunej]

It seems #4346 should had already fixed this.