Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proxy] Pass extra parameters to the console #2467

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

funbringer
Copy link
Contributor

With this change we now pass additional params to the console's auth methods.

@funbringer funbringer changed the title Pass extra parameters to the console [proxy] Pass extra parameters to the console Sep 16, 2022
@funbringer funbringer force-pushed the fubringer/proxy-console-extra-params branch from 9ff9a11 to 3defe32 Compare September 16, 2022 16:19
@funbringer funbringer force-pushed the fubringer/proxy-console-extra-params branch from 3defe32 to 57ae96e Compare September 19, 2022 13:58
@funbringer funbringer linked an issue Sep 19, 2022 that may be closed by this pull request
@funbringer funbringer force-pushed the fubringer/proxy-console-extra-params branch from 57ae96e to 9cda599 Compare September 19, 2022 17:12
Copy link
Contributor

@LizardWizzard LizardWizzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Liked your Cow usage pattern

Minor comments

@funbringer funbringer force-pushed the fubringer/proxy-console-extra-params branch from 9cda599 to 5891233 Compare September 21, 2022 11:17
@funbringer funbringer requested a review from ololobus September 21, 2022 11:17
@funbringer funbringer force-pushed the fubringer/proxy-console-extra-params branch from 5891233 to c39c42b Compare September 21, 2022 11:19
With this change we now pass additional params
to the console's auth methods.
@funbringer funbringer force-pushed the fubringer/proxy-console-extra-params branch from c39c42b to f8422d2 Compare September 21, 2022 17:09
@funbringer funbringer merged commit e9a103c into main Sep 21, 2022
@funbringer funbringer deleted the fubringer/proxy-console-extra-params branch September 21, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forward application_name to the console
4 participants