[wokdlhX3] Extract code from APOC core which is only used in APOC extended #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lojjs
force-pushed
the
dev-move-parts-of-common-to-extended
branch
29 times, most recently
from
297611d to
f4b9217
Compare
Lojjs
force-pushed
the
dev-move-parts-of-common-to-extended
branch
2 times, most recently
from
4f190ba to
cd8daa4
Compare
conker84
suggested changes
Dec 14, 2022
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| import static java.net.HttpURLConnection.HTTP_OK; | |||
|
|
|||
| @SuppressWarnings("unused") // used from extended | |||
There was a problem hiding this comment.
I would prefer moving this on extended as it's used only in there as you did for many other APIs
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| import java.time.Duration; | |||
|
|
|||
| @SuppressWarnings("unused") // used from extended | |||
There was a problem hiding this comment.
Same as GoogleCloudStorageContainerExtension
| @@ -139,23 +139,4 @@ private void requireConnected(Relationship relationship) { | |||
| throw new IllegalArgumentException("Relationship is not part of current path."); | |||
| } | |||
| } | |||
|
|
|||
| public static final class Builder { | |||
There was a problem hiding this comment.
I prefer to have it in there, now it's used only in DataVirtualizationCatalog but by design would be better having it in there; as in the future could be used in other use-cases
|
@Lojjs can you please rebase it? |
The Admin annotation will be used instead for extended
The previous one used a private constructor.
… extended These usages are not as straight forward to get rid of/extract to extended.
Lojjs
force-pushed
the
dev-move-parts-of-common-to-extended
branch
from
4e80267 to
258772a
Compare
Lojjs
force-pushed
the
dev-move-parts-of-common-to-extended
branch
from
46c818c to
ea01825
Compare
conker84
approved these changes
Jan 16, 2023
|
@Lojjs LGTM thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should go in together with neo4j-contrib/neo4j-apoc-procedures#3361