[wokdlhX3] Extract code from APOC core which is only used in APOC extended #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conker84
requested changes
Dec 14, 2022
| .map(PathResult::new); | ||
| } | ||
|
|
||
| private static final class VirtualPathBuilder { |
There was a problem hiding this comment.
I would prefer to leave the API in VirtualPath in core
| @@ -87,7 +88,8 @@ private String[] getHeader(CSVReader csv, LoadCsvConfig config) throws IOExcepti | |||
| Map<String, Mapping> mappings = config.getMappings(); | |||
| for (int i = 0; i < headers.length; i++) { | |||
| String header = headers[i]; | |||
| if (ignore.contains(header) || mappings.getOrDefault(header, Mapping.EMPTY).ignore) { | |||
| Mapping empty = new Mapping("", Collections.emptyMap(), LoadCsvConfig.DEFAULT_ARRAY_SEP, false); | |||
There was a problem hiding this comment.
Maybe adding it as a static final?
Lojjs
force-pushed
the
dev-move-parts-of-common-from-core
branch
from
de07bcf to
830df13
Compare
Lojjs
force-pushed
the
dev-move-parts-of-common-from-core
branch
from
b595562 to
55fbd1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should go in together with neo4j/apoc#261