Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gRNAet7B] Fixes trigger procedures in clusters for neo4j 5.x #250

Merged
merged 20 commits into from
Jan 9, 2023
Merged

[gRNAet7B] Fixes trigger procedures in clusters for neo4j 5.x #250

merged 20 commits into from
Jan 9, 2023

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Nov 22, 2022 •
edited
Loading

@vga91 vga91 marked this pull request as draft November 22, 2022 14:31
@vga91 vga91 force-pushed the dev-fix-trigger-procedures branch 3 times, most recently from 99044fc to e4669fa Compare November 22, 2022 21:31
@vga91 vga91 mentioned this pull request Nov 22, 2022
Closed
@vga91 vga91 force-pushed the dev-fix-trigger-procedures branch from d4608d4 to 05098f6 Compare November 23, 2022 08:18
@vga91 vga91 marked this pull request as ready for review November 23, 2022 08:54
@vga91 vga91 force-pushed the dev-fix-trigger-procedures branch 2 times, most recently from cff9027 to 5e92364 Compare December 15, 2022 15:22
@vga91 vga91 force-pushed the dev-fix-trigger-procedures branch from 5e92364 to 1a0c361 Compare December 16, 2022 08:02
@vga91 vga91 force-pushed the dev-fix-trigger-procedures branch from cacdf54 to 0284596 Compare December 16, 2022 16:21
@vga91 vga91 mentioned this pull request Dec 20, 2022
Closed
@vga91 vga91 force-pushed the dev-fix-trigger-procedures branch 4 times, most recently from 26cb203 to f1e0e98 Compare December 22, 2022 17:13
vga91 and others added 14 commits January 5, 2023 12:35
@vga91
[gRNAet7B] fix some tests
1e0f15e
@vga91
[gRNAet7B] fix TriggerClusterRoutingTest
1017352
@vga91
[gRNAet7B] fix TriggerRouting error message
05135ab
@vga91
[gRNAet7B] Added trigger show procedure (neo4j-contrib/neo4j-apoc-pro…
61acbdc 
…cedures#3335)

* Fix flaky trigger dbms availability tests
* added apoc.trigger.show proc
* retry to fix flaky test by separating setLastUpdate()
* removed updated output - some code refactoring
* split pr - changes review
* removed inner transaction
* updated documentation
* reset wrong generated docs
* Added admin in trigger.show
* small adoc changes
@vga91
[gRNAet7B] Try de-flaky some tests with new procedure triggers (neo4j…
5dc42cb 
…-contrib/neo4j-apoc-procedures#3355)

* Try de-flaky some tests with new procedure triggers
* moved TriggerTestUtil and increased trigger.refresh value
* added waitDbsAvailable util
@vga91
[gRNAet7B] removed unused import
df9f610
@vga91
[gRNAet7B] fix cluster test
4574be9
@vga91
[gRNAet7B] added documentation about new trigger procedures and depre…
ecd2d55 
…cated ones (neo4j-contrib/neo4j-apoc-procedures#3325)

* [gRNAet7B] added trigger new procs documentation
* changes review - procedure description
* changed listener wording
* added system db note
* var. small changes
@AzuObs @vga91
[gRNAet7B] Fixes triggers (neo4j-contrib/neo4j-apoc-procedures#3369)
0a7a284 
* [coZSswV2] Fix typo in triggers error message

* [coZSswV2] Assert new triggers can't add TransactionEventListeners to "system"

* [coZSswV2] Assert old triggers can't add TransactionEventListeners to "system"
@vga91
[gRNAet7B] removed unused import
84de519
@vga91
[gRNAet7B] moved TriggerInfo class, removed wrong extended file
1e1ab54
@vga91
[gRNAet7B] Add @Admin to trigger procedures (neo4j-contrib/neo4j-apoc…
c05b408 
…-procedures#3357)

* [qwJFy8pp] Add @Admin to trigger procedures
* added admin in trigger.list and docs note
* changed admin doc
@vga91
[gRNAet7B] moved classes - changed TriggerInfo - err. handling changes
9db6305
@vga91
[gRNAet7B] Cleanup trigger docs (neo4j-contrib/neo4j-apoc-procedures#…
b5dc570 
…3378)
@vga91 vga91 force-pushed the dev-fix-trigger-procedures branch from b845ea0 to 767e26e Compare January 5, 2023 11:35
@vga91 vga91 force-pushed the dev-fix-trigger-procedures branch from f1f9f31 to 27adcff Compare January 5, 2023 13:16
AzuObs
AzuObs approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@AzuObs AzuObs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for all the hard work. It looks great 💃

@vga91 vga91 merged commit c575792 into dev Jan 9, 2023
@vga91 vga91 deleted the dev-fix-trigger-procedures branch January 9, 2023 08:18
This was referenced Jan 9, 2023
Closed
Closed
Closed
vga91 added a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this pull request Jan 9, 2023
@vga91
[gRNAet7B] Changes from neo4j/apoc#250
f01e18a
@vga91 vga91 mentioned this pull request Jan 9, 2023
Merged
vga91 added a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this pull request Jan 10, 2023
@vga91
[gRNAet7B] Changes from neo4j/apoc#250
73ce89a
vga91 added a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this pull request Jan 12, 2023
@vga91
[gRNAet7B] Changes from neo4j/apoc#250 (#3393)
3fe6957 
* [gRNAet7B] Changes from neo4j/apoc#250

* [gRNAet7B] Changed AtomicReference with 1-elem array
@vga91 vga91 mentioned this pull request Jan 13, 2023
Merged
@vga91 vga91 mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzuObs AzuObs AzuObs approved these changes

Assignees

@AzuObs AzuObs

Labels
dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vga91 @AzuObs @ncordon