Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gRNAet7B] Fixes trigger procedures in clusters for neo4j 5.x (extended part) #3330

Closed
wants to merge 2 commits into from
Closed

[gRNAet7B] Fixes trigger procedures in clusters for neo4j 5.x (extended part) #3330

wants to merge 2 commits into from

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Nov 22, 2022

TODO: Waiting for neo4j/apoc#250
Change .gitmodules branch to dev when the pr is merged

@vga91 vga91 added extended-functionality 5.3 (dev branch) cherry-picked This PR has been cherry-picked to the other active branches labels Nov 22, 2022
ncordon
ncordon requested changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@ncordon ncordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably these tests should be moved to core?

@vga91
Copy link
Collaborator Author

vga91 commented Nov 28, 2022

Probably these tests should be moved to core?

They are on extended because leverage on extended functions, e.g. apoc.trigger.nodesByLabel.

ncordon
ncordon reviewed Jan 5, 2023
View reviewed changes
.gitmodules Outdated
@@ -1,4 +1,4 @@
[submodule "apoc-core"]
path = apoc-core
url = https://github.com/neo4j/apoc
branch = dev
branch = dev-fix-trigger-procedures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should always point to dev

ncordon
ncordon reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@ncordon ncordon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, happy to approve once the branch of the submodule has been changed and the flaky tests failing in the CI are hardened (e.g. TriggerClusterTest)

@vga91 vga91 force-pushed the dev-fix-trigger-procedures_extended branch 3 times, most recently from aba6ab4 to b9bb9cd Compare January 9, 2023 10:53
@vga91 vga91 force-pushed the dev-fix-trigger-procedures_extended branch from b9bb9cd to fe96a33 Compare January 9, 2023 11:26
@vga91 vga91 closed this Jan 9, 2023
@vga91
Copy link
Collaborator Author

vga91 commented Jan 11, 2023

Closed in favor of #3391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncordon ncordon ncordon requested changes

Assignees

@ncordon ncordon

Labels
5.3 (dev branch) cherry-picked This PR has been cherry-picked to the other active branches extended-functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vga91 @ncordon