Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scalars for temporal types #235

Merged
merged 1 commit into from
Jun 12, 2021
Merged

Use scalars for temporal types #235

merged 1 commit into from
Jun 12, 2021

Conversation

Andy2003
Copy link
Collaborator

@Andy2003 Andy2003 commented Jun 11, 2021 •
edited
Loading

With these changes a new configuration param useTemporalScalars was introduced. With this configuration enabled, neo4js' temporales like Date, Time, LocalTime, DateTime and LocalDateTime are used as scalars (strings).

resolves #223
resolves #109
resolves #108
resolves #93

@Andy2003
Use scalars for temporal types
4c3a6f8 
With these changes a new configuration param `useTemporalScalars` was introduced. With this configuration enabled, neo4js' temporales like `Date`, `Time`, `LocalTime`, `DateTime` and `LocalDateTime` are used as scalars (strings).

resolves #223, #109, #108, #93
@Andy2003 Andy2003 added the API-Alignment Align the API with the one defined by @neo4j/graphql label Jun 11, 2021
@github-actions
Copy link

github-actions bot commented Jun 11, 2021 •
edited
Loading

Unit Test Results

    5 files  ±0      5 suites  ±0   59s ⏱️ ±0s
184 tests ±0  180 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
715 runs  ±0  709 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 54a483c. ± Comparison against base commit 54a483c.

♻️ This comment has been updated with latest results.

@Andy2003 Andy2003 mentioned this pull request Jun 11, 2021
Closed
@Andy2003 Andy2003 requested a review from jexp June 11, 2021 16:52
@Andy2003 Andy2003 merged commit 54a483c into master Jun 12, 2021
@Andy2003 Andy2003 deleted the feature/use_temporal_as_scalars branch June 12, 2021 15:54
@Andy2003 Andy2003 mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jexp jexp Awaiting requested review from jexp

Assignees
No one assigned
Labels
API-Alignment Align the API with the one defined by @neo4j/graphql
Projects
None yet
Milestone
No milestone
1 participant
@Andy2003