Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datetime comparisons for filtering (#93) #229

Closed
wants to merge 1 commit into from

Conversation

rbramley
Copy link
Contributor

Issue #93 (plus others like #223) requires the ability to perform filtering with simple date comparisons.

This patch determines whether a type is a Neo4j Date/Time and augments it with filters for GT/GTE/LT/LTE (over and above the existing augmentation for a Neo4j type).

@Andy2003
Copy link
Collaborator

Currently we are trying to harmonize our API with that of the official JavaScipt version (https://github.com/neo4j/graphql).
In this sense we should replace the (input-) types like _Neo4jDateTime etc. by simple scalars which transfer the date / time as iso string.
With this in place you would pass a complete date / time iso string in the filter.

see also:

https://github.com/neo4j/graphql/blob/master/packages/graphql/tests/tck/tck-test-files/schema/types/datetime.md
https://github.com/neo4j/graphql/blob/master/packages/graphql/tests/tck/tck-test-files/cypher/types/datetime.md

This means we need some refactoring:

  • configuration to switch behavior until next major release
  • implementation of the new scalars
  • adjusting of the generated cypher

@Andy2003
Copy link
Collaborator

The adjustments mentioned in #229 (comment) are implemented via #235

@Andy2003 Andy2003 closed this Jun 11, 2021
@Andy2003 Andy2003 added API-Alignment Align the API with the one defined by @neo4j/graphql enhancement New feature or request labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-Alignment Align the API with the one defined by @neo4j/graphql enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants