[NOID] Fixes circular docker dependency in TeamCity #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lojjs
approved these changes
May 24, 2023
ncordon
force-pushed
the
fix-circular-docker-dep
branch
from
83651ab to
8b19bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A dedicated property
neo4jDockerVersionOverridehas been created in TeamCity so we can pass a different version for neo4j and neo4j docker. This means we could be building with neo4j 4.4.22 when docker is still at 4.4.21Why
Because in some instances the docker job will not have the same neo4j version, since there's a circular dependency where in apoc we depend on docker and to build a docker container we depend on apoc been built and packaged with the database.
#3588 seemed to broke the TeamCity CI for 4.4