Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOID] Solves CI bug with NEO4J_VERSION variable not being available #3588

Merged
merged 1 commit into from
May 22, 2023

Conversation

ncordon
Copy link
Contributor

@ncordon ncordon commented May 22, 2023

Cherry picked from neo4j/apoc#395

What

Changes System.getProperty("NEO4JVERSION") for project.hasProperty("neo4jVersionOverride") in the docker images version.

Why

Because when they've updated the TeamCity jobs to bump the neo4j version, NEO4JVERSION was never available because it was never set a system property, causing the docker containers to say:

  Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=neo4j:5.8.0-enterprise, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@278fe428)

Further down the file we do set the neo4j version correctly for the Java artifacts:

ext {
    publicDir =  "${project.rootDir}"
    neo4jVersionEffective = project.hasProperty("neo4jVersionOverride") ? project.getProperty("neo4jVersionOverride") : "5.9.0"
    testContainersVersion = '1.17.6'
}

@ncordon ncordon added cherry-picked This PR has been cherry-picked to the other active branches 4.4 bug labels May 22, 2023
@ncordon ncordon merged commit fe9d772 into 4.4 May 22, 2023
@ncordon ncordon deleted the 4.4-removes-NEO4J_VERSION branch May 22, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 bug cherry-picked This PR has been cherry-picked to the other active branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant