Skip to content

Commit

Permalink
iio: ad9523: Fix return value for ad952x_store()
Browse files Browse the repository at this point in the history
commit 9a5094c upstream.

A sysfs write callback function needs to either return the number of
consumed characters or an error.

The ad952x_store() function currently returns 0 if the input value was "0",
this will signal that no characters have been consumed and the function
will be called repeatedly in a loop indefinitely. Fix this by returning
number of supplied characters to indicate that the whole input string has
been consumed.

Signed-off-by: Lars-Peter Clausen <[email protected]>
Signed-off-by: Alexandru Ardelean <[email protected]>
Fixes: cd1678f ("iio: frequency: New driver for AD9523 SPI Low Jitter Clock Generator")
Cc: <[email protected]>
Signed-off-by: Jonathan Cameron <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
larsclausen authored and gregkh committed Sep 9, 2018
1 parent a3442d6 commit 76eb62b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/iio/frequency/ad9523.c
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ static ssize_t ad9523_store(struct device *dev,
return ret;

if (!state)
return 0;
return len;

mutex_lock(&indio_dev->mlock);
switch ((u32)this_attr->address) {
Expand Down

0 comments on commit 76eb62b

Please sign in to comment.