Fix scripts for Windows environment #118
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/covid19-scenarios/covid19-scenarios/nvk1nof3g |
|
I just realized now that there was already an opened pull request for this issue (#114) a few hours ago. |
|
I've been working on this slowly in parallel too and I decided to crowdtest it here: and in the end merged my changes, which I found more comprehensive and less breaking. I will close this for now. But if you still need to adjust something, feel free to jump in to #38 or in the chat or to make another PR |
| "lint": "yarn eslint && yarn stylelint && yarn tsc && yarn tslint", | ||
| "lint:fix": "yarn eslint:fix && yarn tsc && yarn tslint:fix", |
There was a problem hiding this comment.
This is not the same behavior. This will stop after the first command that errors out.
I'd prefer to see all the errors, in both dev and CI environment.
I think we could just add spaces around semicolons. That should unscrew Windows.
There was a problem hiding this comment.
Hey @ivan-aksamentov ,
the line:
node -e 'console.clear()' ; yarn dev:clean ; yarn install && yarn dev:nowatch || cd .
doesn't properly work for me on Windows (neither with Powershell nor default CMD shell, maybe with a bash shell?)
it actually runs just the part after && (yarn dev:nowatch, etc) and skips the part before (clear, dev:clean, install).
yes, it properly runs the server etc but ';' doesn't seem to work properly on Win (at least for me).
There was a problem hiding this comment.
If you want, you can play with
https://www.npmjs.com/package/npm-run-all
in particular, run-s with -c flag when appropriate
https://github.com/mysticatea/npm-run-all/blob/HEAD/docs/run-s.md
Let's hope it won't cause too many troubles on Unix.
There was a problem hiding this comment.
@ivan-aksamentov
It simplifies "lint" scripts quite a bit:
"lint": "run-s -c eslint stylelint tsc tslint",
"lint:fix": "run-s -c eslint:fix tsc tslint:fix",
but clutters a bit more "dev" ("prod") scripts as
"exec": "run-s -c clear dev:clean dev:start || cd ." in dev.json
needs definitely adding "dev:start" and even "clear" to package.json:
"dev:start": "yarn install && yarn dev:nowatch",
Maybe it is a bit cleaner this way, on the other hand this exec line could be run even sequentially with exit on error:
"exec": "node -e 'console.clear()' && yarn dev:clean && yarn install && yarn dev:nowatch || cd ."
to compromise complexity.
Let me know If I should open a PR. thanks.
There was a problem hiding this comment.
@mickeypearce Mickey, absolutely, open a PR! And thanks for the investigation.
Description
Fixing package.json scripts for Win environment
Related issues
Impacted Areas in the application
Testing
Deploy Notes