#38 support windows development #114
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/covid19-scenarios/covid19-scenarios/493cguk2a |
eloisetaylor5693
changed the title
| host: '0.0.0.0', | ||
| host: '127.0.0.1', |
There was a problem hiding this comment.
It will break for people who work on remote machines. Why are these necessary?
It works for me with 0.0.0.0 on Windows 7 VM.
If it is really necessary, please make it configurable through an environment variable and add to .env.example file
There was a problem hiding this comment.
On both my windows machines, 0.0.0.0 didn't work. 127.0.0.1 is the standard localhost IP address.
There was a problem hiding this comment.
@eloisetaylor5693 Could you please patch and verify it for us?
Add and .env variable and set it to 127.0.0.1 by default. Refer to this variable in webpack config. Those who need remote will change the var to 0.0.0.0,
Thanks for your investigation!
| "preprod": "node -e 'console.clear()' && yarn install && yarn prod:clean", | ||
| "prod": "cross-env NODE_ENV=production BABEL_ENV=production webpack --config config/webpack/webpack.client.babel.ts", |
There was a problem hiding this comment.
Using pre- hooks only makes things even more confusing in my already super-confusing setup. =)
Could we avoid that? As Microsoft folks explained in the issue thread, it is sufficient to just add spaces around semicolons ;.
In fact I was also working on it in parallel and it indeed works.
|
I've been working on this slowly in parallel too and I decided to crowdtest it here: and in the end merged my changes, which I found more comprehensive and less breaking. I will close this for now. But if you still need to adjust something, feel free to jump in to #38 or in the chat or to make another PR |
#38 Added support for Windows development.
I didn't test every npm script.
Side note: I think the script should be called
startinstead ofdev. egyarn startoryarn serve:dev