fix(evm): Added betanet evm chain id and renamed test_evm to testnet_evm #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chefsale
requested review from
bowenwang1996,
evgenykuzyakov,
frol,
maxzaver,
olonho,
SkidanovAlex and
willemneal
as code owners
artob
reviewed
Jan 12, 2021
|
@frol @bowenwang1996 @SkidanovAlex can somebody of the owners take a look at this PR? 😄 |
bowenwang1996
approved these changes
Jan 12, 2021
|
@olonho @willemneal @evgenykuzyakov One more codeowner review needed from you gents... |
willemneal
approved these changes
Jan 13, 2021
|
@evgenykuzyakov And one last codeowner review from you needed, pretty please. |
evgenykuzyakov
approved these changes
Jan 13, 2021
|
Do we need to bump Protocol Version every time? |
@evgenykuzyakov In this specific case, no, because I bumped it in #3773 which was merged just prior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.