-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM BetaNet returns MainNet chain ID #3781
Comments
This is a configuration issue on the betanet in the genesis.json CC @chefsale |
I just checked the genesis.json hosted on S3 here: https://s3.console.aws.amazon.com/s3/object/build.nearprotocol.com?region=us-west-1&prefix=nearcore-deploy/betanet/genesis.json which nearup is using and the current betanet network RPC also returns betanet: http://rpc.betanet.near.org/status. @artob are you sure you are have setup the node correctly? Can you provide more information on how did you reproduce this? |
@artob also if you are just running: |
@chefsale Sorry for confusion, this issue is not about |
@chefsale Yes, as @ilblackdragon noted, this is about what the EVM's |
It seems like the only place where we specify the chain ids for evm is here: https://github.com/near/nearcore/blob/master/core/chain-configs/src/genesis_config.rs, but we specify them for MAINNET_EVM_CHAIN_ID and TEST_EVM_CHAIN_ID, but we don't for betanet, so this seems like it's missing and is probably the cause for this. Just and assumption. cc: @artob |
And then here: https://github.com/near/nearcore/blob/master/neard/src/runtime.rs#L1397 we are not handling this properly, sending a fix. |
PR which I believe should be the fix: #3800 cc: @mikedotexe @artob @ilblackdragon |
@artob, sure they should be deployed in 20 minutes by the daily cron job. |
@artob the deploy has happened: https://buildkite.com/nearprotocol/deploy-betanet/builds/210. It was already done when you pinged me I just mixed up the time of the cron job. |
Turns out near-web3-provider has a bug regarding chain IDs (aurora-is-near/near-web3-provider#71), so I'll need to test this by deploying an actual Solidity contract. I'll aim to come back to this tomorrow. |
@artob what is the latest on this? |
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. |
As discussed on our 2021-01-04 call, the EVM's [
CHAINID
](https://eips.ethereum.org/EIPS/eip-1344) opcode on betanet currently returns the registered value for mainnet:The text was updated successfully, but these errors were encountered: