Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resharding): remove obsolete todos #12858

Merged
merged 1 commit into from
Feb 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion chain/chain/src/garbage_collection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,6 @@ impl<'a> ChainStoreUpdate<'a> {
Ok(())
}

// TODO(resharding) Revisit this function, probably it is not needed anymore.
fn get_shard_uids_to_gc(
&mut self,
epoch_manager: &dyn EpochManagerAdapter,
Expand Down
2 changes: 0 additions & 2 deletions chain/chain/src/resharding/manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,13 @@ impl ReshardingManager {
/// Store in the database the mapping of ShardUId from children to the parent shard,
/// so that subsequent accesses to the State will use the ancestor's ShardUId prefix
/// as a prefix for the database key.
// TODO(resharding) add testloop where grandparent ShardUId is used
fn set_state_shard_uid_mapping(
&mut self,
split_shard_event: &ReshardingSplitShardParams,
) -> io::Result<()> {
let mut store_update = self.store.trie_store().store_update();
let parent_shard_uid = split_shard_event.parent_shard;
let parent_shard_uid_prefix = get_shard_uid_mapping(&self.store, parent_shard_uid);
// TODO(resharding) No need to set the mapping for children shards that we won't track just after resharding?
for child_shard_uid in split_shard_event.children_shards() {
store_update.set_shard_uid_mapping(child_shard_uid, parent_shard_uid_prefix);
}
Expand Down
1 change: 0 additions & 1 deletion core/store/src/archive/cold_storage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,6 @@ pub fn copy_all_data_to_cold(
tracing::debug!(target: "cold_store", "stopping copy_all_data_to_cold");
return Ok(CopyAllDataToColdStatus::Interrupted);
}
// TODO(resharding) Should do mapping here?
let (key, value) = result?;
transaction.set_and_write_if_full(col, key.to_vec(), value.to_vec())?;
}
Expand Down
1 change: 0 additions & 1 deletion core/store/src/trie/mem/parallel_loader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ impl ParallelMemTrieLoader {
arena: &mut impl ArenaMut,
) -> Result<MemTrieNodeId, StorageError> {
// Figure out which range corresponds to the prefix of this subtree.
// TODO(resharding) This seems fragile, potentially does not work with mapping.
let (start, end) = subtree_to_load.to_iter_range(self.shard_uid);

// Load all the keys in this range from the FlatState column.
Expand Down
1 change: 0 additions & 1 deletion integration-tests/src/test_loop/tests/resharding_v3.rs
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,6 @@ fn slow_test_resharding_v3() {
test_resharding_v3_base(TestReshardingParametersBuilder::default().build());
}

// TODO(resharding) Add test with double resharding (not independent) when it is supported.
#[test]
fn slow_test_resharding_v3_two_independent_splits() {
let second_resharding_boundary_account = "account2".parse().unwrap();
Expand Down
Loading