Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resharding): remove obsolete todos #12858

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

staffik
Copy link
Contributor

@staffik staffik commented Jan 31, 2025

No description provided.

@staffik staffik requested review from wacban and Trisfald January 31, 2025 20:44
@staffik staffik requested a review from a team as a code owner January 31, 2025 20:44
@staffik staffik changed the title chore(resharding): remove obsolet todos chore(resharding): remove obsolete todos Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (6e0ec41) to head (5db5550).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12858   +/-   ##
=======================================
  Coverage   70.40%   70.40%           
=======================================
  Files         852      853    +1     
  Lines      174177   174113   -64     
  Branches   174177   174113   -64     
=======================================
- Hits       122626   122588   -38     
+ Misses      46305    46299    -6     
+ Partials     5246     5226   -20     
Flag Coverage Δ
backward-compatibility 0.35% <ø> (+<0.01%) ⬆️
db-migration 0.35% <ø> (+<0.01%) ⬆️
genesis-check 1.41% <ø> (+<0.01%) ⬆️
linux 70.07% <ø> (+<0.01%) ⬆️
linux-nightly 70.03% <ø> (+0.01%) ⬆️
pytests 1.72% <ø> (+<0.01%) ⬆️
sanity-checks 1.52% <ø> (+<0.01%) ⬆️
unittests 70.23% <ø> (+<0.01%) ⬆️
upgradability 0.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@staffik staffik added this pull request to the merge queue Feb 2, 2025
Merged via the queue into master with commit db076d7 Feb 2, 2025
29 checks passed
@staffik staffik deleted the stafik/resharding/delete-todos branch February 2, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants