Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Remove initializeOffsets calling from SQL Table write #435

Closed
mikir opened this issue Nov 1, 2022 · 0 comments
Closed

C++: Remove initializeOffsets calling from SQL Table write #435

mikir opened this issue Nov 1, 2022 · 0 comments
Assignees
@mikir
Labels
c++ C++ language generator enhancement New feature or request
Milestone
2.9

Comments

@mikir
Copy link
Contributor

mikir commented Nov 1, 2022

Currently, SQL table write() method always calls initializeOffsets() method for all blobs. This can bring extra unnecessary overhead. It is natural that user application is responsible for correct settings of blobs. So if it is really necessary, application can call initializeOffsets() method by itself.

Therefore, it could be ok to remove calling of initializeOffsets() method completely from SQL Table write() method.
@mikir mikir added enhancement New feature or request c++ C++ language generator labels Nov 1, 2022
@mikir mikir added this to the 2.9 milestone Nov 1, 2022
@mikir mikir self-assigned this Nov 1, 2022
mikir added a commit that referenced this issue Nov 1, 2022
@mikir
[#435] Remove initializeOffsets calling from SQL Table write
7391284
@mikir mikir closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikir mikir

Labels
c++ C++ language generator enhancement New feature or request
Projects
None yet
Milestone
2.9
Development

No branches or pull requests
1 participant
@mikir