[#435] Remove initializeOffsets calling from SQL Table write

Author: mikir

compiler/extensions/cpp/freemarker/Sql.inc.ftl

@@ -7,15 +7,6 @@
     <#return false>
 </#function>
 
-<#function sql_table_has_blob_field fields>
-    <#list fields as field>
-        <#if field.sqlTypeData.isBlob>
-            <#return true>
-        </#if>
-    </#list>
-    <#return false>
-</#function>
-
 <#function sql_db_has_without_rowid_table fields>
     <#list fields as field>
         <#if field.isWithoutRowIdTable>

compiler/extensions/cpp/freemarker/SqlTable.cpp.ftl

@@ -25,7 +25,6 @@
 <@namespace_begin package.path/>
 
 <#assign needsParameterProvider=explicitParameters?has_content/>
-<#assign hasBlobField=sql_table_has_blob_field(fields)/>
 <#if withValidationCode>
     <#assign hasPrimaryKeyField=false/>
     <#list fields as field>
@@ -697,10 +696,6 @@ void ${name}::writeRow(<#if needsParameterProvider>IParameterProvider& parameter
 <#if needsChildrenInitialization>
     row.initializeChildren(<#if needsParameterProvider>parameterProvider</#if>);
 
-</#if>
-<#if hasBlobField>
-    row.initializeOffsets();
-
 </#if>
     int result;
 
@@ -897,18 +892,6 @@ void ${name}::Row::initializeChildren(<#if needsParameterProvider>IParameterProv
     }
             </#if>
         </#list>
-}
-    </#if>
-    <#if hasBlobField>
-
-void ${name}::Row::initializeOffsets()
-{
-        <#list fields as field>
-            <#if field.sqlTypeData.isBlob>
-    if (<@sql_field_member_name field/>)
-        <@sql_field_member_name field/>->initializeOffsets();
-            </#if>
-        </#list>
 }
     </#if>
 </#if>

compiler/extensions/cpp/freemarker/SqlTable.h.ftl

@@ -27,7 +27,6 @@
 <@namespace_begin package.path/>
 
 <#assign needsParameterProvider=explicitParameters?has_content/>
-<#assign hasBlobField=sql_table_has_blob_field(fields)/>
 <#if withValidationCode>
     <#assign hasNonVirtualField=sql_table_has_non_virtual_field(fields)/>
 </#if>
@@ -233,17 +232,6 @@ public:
         void initializeChildren(<#if needsParameterProvider>IParameterProvider& parameterProvider</#if>);
 
     </#if>
-    <#if hasBlobField>
-        <#if withCodeComments>
-        /**
-         * Initializes offsets in all blob fields of the table.
-         *
-         * This method sets offsets in all blob fields recursively.
-         */
-        </#if>
-        void initializeOffsets();
-
-    </#if>
 </#if>
     private:
 <#if hasImplicitParameters>

test/language/sql_tables/cpp/BlobOffsetsParamTableTest.cpp

@@ -53,6 +53,8 @@ class BlobOffsetsParamTableTest : public ::testing::Test
         vector_type<uint32_t>& array = parameterizedBlob.getArray();
         for (uint32_t i = 0; i < array_size; ++i)
             array.push_back(i);
+        parameterizedBlob.initialize(row.getOffsetsHolder());
+        parameterizedBlob.initializeOffsets();
     }
 
     static void fillBlobOffsetsParamTableRows(vector_type<BlobOffsetsParamTable::Row>& rows)