Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add MOD metadata to submission object #175

Merged
merged 12 commits into from
Mar 7, 2025

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented Mar 7, 2025

Changes

  • Use the new ontologies_linked_data model with MOD
  • Update populate_from_params helper to support URI attributes
  • Add submission and ontologies metadata endpoints
  • ruby 3.0.6 -> 3.1.6 update

See

@alexskr alexskr changed the title Feature/add mod metadata to submission object Feature/add MOD metadata to submission object Mar 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 38.35616% with 45 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (4cfee2a) to head (7e09f16).

Files with missing lines Patch % Lines
helpers/metadata_helper.rb 16.27% 36 Missing ⚠️
helpers/application_helper.rb 72.00% 7 Missing ⚠️
controllers/submission_metadata_controller.rb 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
- Coverage    73.34%   72.48%   -0.87%     
===========================================
  Files           53       55       +2     
  Lines         2953     3009      +56     
===========================================
+ Hits          2166     2181      +15     
- Misses         787      828      +41     
Flag Coverage Δ
unittests 72.48% <38.35%> (-0.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexskr alexskr merged commit 49f7955 into develop Mar 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants