-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Upgrade Postgres version from 14.6 to 16.2 #627
Conversation
2. (if needed) Update the `serverlessv2_scaling_configuration` | ||
|
||
Set the `min_capacity` to 4.0 (and adjust the `max_capacity` accordingly). | ||
If your minimum is lower than this, the upgrade will fail with `FATAL: shared memory segment sizes are configured too large`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once committed, this documentation will be the second reference ever to this error on Google 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rollout notes: Once this is merged we'll need to run through these migration steps on the platform-test and https://github.com/navapbc/platform-test-flask repos. Lemme know if you need access to the AWS accounts for those
Ticket
Resolves #523
Changes
Small tweaks to the code to make upgrading major versions slightly easier:
allow_major_version_change = false
-- this is the default, but making it explicit makes it easier for teams to know where this should be updated when they need to change it to trueRemove revocation of create on public schema from role_manager.py-- this is now the default as of Postgres 15, but I'm leaving this behavior "as is" so folks can continue to use the infra template with past versions of Postgres safely.Context for reviewers
Testing
I manually tested the instructions on my AWS account:
I reviewed this list for potential incompatibilities between 14 and 15, and this list of potential incompatibilities between 15 and 16.
Besides a change to default permissions, I don't think there are any incompatibilities with the infra template.
Role inheritance now controls the default inheritance status of member roles added during [GRANT](https://www.postgresql.org/docs/16/sql-grant.html)
I will put up sibling PRs that check this for the Application Flask template (and the NextJS one if it uses a database as well.)