Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Postgres to 16 #225

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Bump Postgres to 16 #225

merged 1 commit into from
Jun 11, 2024

Conversation

KevinJBoyer
Copy link
Contributor

Ticket

Resolves #218

Changes

Change Docker image used for local development to Postgres 16.

Context for reviewers

Sibling PR for bump to 16.2 in the infra template.

Testing

All existing tests pass.

@KevinJBoyer KevinJBoyer requested a review from chouinar June 7, 2024 12:33
@KevinJBoyer
Copy link
Contributor Author

@chouinar to coordinate with the change in the infra template, I went ahead and requested your review on this -- I'll plan to merge this if/when the corresponding infra template PR is merged.

@KevinJBoyer KevinJBoyer marked this pull request as ready for review June 7, 2024 12:34
Copy link
Contributor

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Skimming through the changelog for Postgres 16, I don't see anything that should impact anything locally, but there are a ton of changes.

https://www.postgresql.org/docs/release/16.0/

@lorenyu
Copy link
Contributor

lorenyu commented Jun 7, 2024

aws docs seem to indicate that we can only go up to 15.6 from 14.6

so we might need to do this in two steps/PRs
image

@chouinar
Copy link
Contributor

chouinar commented Jun 7, 2024

aws docs seem to indicate that we can only go up to 15.6 from 14.6

so we might need to do this in two steps/PRs image

Wouldn't be an issue with the docker-compose file since that only affects your local instance of the DB. If you want to be very careful, you could upgrade this to v15 when the infra gets changed, and then upgrade it again to v16

@lorenyu
Copy link
Contributor

lorenyu commented Jun 7, 2024

sorry i thought this was the infra template PR ignore my previous comment

@KevinJBoyer KevinJBoyer merged commit 36382ae into main Jun 11, 2024
@KevinJBoyer KevinJBoyer deleted the kb/bump-postgres-to-16 branch June 11, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres 15
3 participants