Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused ImagineLA chat engine settings from UI #195

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: Remove unused ImagineLA chat engine settings from UI #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/src/chat_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,13 @@ class ImagineLaEngine(BaseEngine):
chunks_shown_min_score: float = -1
chunks_shown_max_num: int = 8

user_settings = [
"llm",
"retrieval_k",
"retrieval_k_min_score",
"system_prompt",
]

Comment on lines +182 to +188
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this just looks like code addition, intent to also remove LOC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare with the parent class BaseEngine.user_settings.

engine_id: str = "imagine-la"
name: str = "Imagine LA Chat Engine"
datasets = ["CA EDD", "Imagine LA", "DPSS Policy", "IRS", "Keep Your Benefits", "CA FTB", "WIC"]
Expand Down
Loading