fix: Remove unused ImagineLA chat engine settings from UI #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fg-nava
reviewed
Jan 23, 2025
Comment on lines
+182
to
+188
| user_settings = [ | ||
| "llm", | ||
| "retrieval_k", | ||
| "retrieval_k_min_score", | ||
| "system_prompt", | ||
| ] | ||
|
|
There was a problem hiding this comment.
this just looks like code addition, intent to also remove LOC?
There was a problem hiding this comment.
Compare with the parent class BaseEngine.user_settings.
fg-nava
approved these changes
Jan 23, 2025
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Slack
Changes
Remove unused ImagineLA chat engine settings from UI
Testing
In chatbot web UI, open the chatbot's settings to ensure those 2 settings don't appear.