Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #4825 #4837

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Revert #4825 #4837

merged 1 commit into from
Nov 30, 2023

Conversation

levb
Copy link
Contributor

@levb levb commented Nov 30, 2023

Revert #4825. It had at least one significant issue that needs to be fixed.

git revert e0d45bd5fcd83d70785ef767493c533684a1cee7 was clean

@levb levb requested a review from a team as a code owner November 30, 2023 20:59
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit 90033d9 into main Nov 30, 2023
@levb levb deleted the lev-revert-unjson branch November 30, 2023 21:19
@levb levb changed the title Revert #4862 Revert #4825 Nov 30, 2023
nabsul pushed a commit to nabsul/nats-server that referenced this pull request Jan 15, 2024
Revert nats-io#4825. It had at least
one significant issue that needs to be fixed.

`git revert e0d45bd` was clean
levb added a commit to levb/nats-server that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants