[IMPROVED] MQTT: do not JSON-encode retained message bodies #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
approved these changes
Nov 29, 2023
neilalexander
pushed a commit
that referenced
this pull request
Nov 30, 2023
#### BREAKING This change is not backwards-compatible. It will break in a mixed environment and/or when downgrading. if a server runs this code, and the cluster/server is reverted to an older version or there are servers in the cluster that are still running older versions, the retained messages will fail to be loaded. #### SUMMARY We used to JSON-encode the payloads of retained messages when storing to JetStream. This PR moves the JSON metadata into the NATS header, and stores the message bytes unencoded in the NATS message body.
Merged
nabsul
pushed a commit
to nabsul/nats-server
that referenced
this pull request
Jan 15, 2024
…4825) This change is not backwards-compatible. It will break in a mixed environment and/or when downgrading. if a server runs this code, and the cluster/server is reverted to an older version or there are servers in the cluster that are still running older versions, the retained messages will fail to be loaded. We used to JSON-encode the payloads of retained messages when storing to JetStream. This PR moves the JSON metadata into the NATS header, and stores the message bytes unencoded in the NATS message body.
nabsul
pushed a commit
to nabsul/nats-server
that referenced
this pull request
Jan 15, 2024
Revert nats-io#4825. It had at least one significant issue that needs to be fixed. `git revert e0d45bd` was clean
derekcollison
added a commit
that referenced
this pull request
Feb 13, 2024
…4825) (#5050) This change is for 2.11 only. As noted in the original PR, downgrading to 2.10 and below would result in data loss for MQTT retained messages (and potential error handling issues). #4825 was reverted from main, adding it back now, with some changes. Specifically, no longer use JSON for the header value; instead use 4 separate headers. The revert was messy, not sure I can reproduce the issue seen in the original PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING
This change is not backwards-compatible. It will break in a mixed environment and/or when downgrading.
if a server runs this code, and the cluster/server is reverted to an older version or there are servers in the cluster that are still running older versions, the retained messages will fail to be loaded.
SUMMARY
We used to JSON-encode the payloads of retained messages when storing to JetStream. This PR moves the JSON metadata into the NATS header, and stores the message bytes unencoded in the NATS message body.