Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing an artifact name in release automation #1728

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fixing an artifact name in release automation #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e37e1d
Fixing an artifact name. RE:#1718
phargogh Jan 6, 2025
e5a3065
Pulling an arbitrary source distribution instead of a specific one. R…
phargogh Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ jobs:

- uses: actions/upload-artifact@v4
with:
# NOTE: if you change this name, make sure the source distribution
# pattern defined in .github/workflows/release-part-2.yml will still
# grab it!
name: Source distribution ${{ matrix.os }} ${{ matrix.python-version }}
path: dist

Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/release-part-2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,18 @@ jobs:
for artifact in Workbench-Windows-binary \
Workbench-macOS-binary \
InVEST-sample-data \
InVEST-user-guide \
"Source distribution"
InVEST-user-guide
do
gh run download $RUN_ID --dir artifacts --name "$artifact"
done

# We build one sdist per combination of OS and python version, so just
# download and unzip all of them into an sdists directory so we can
# just grab the first one. This approach is more flexible to changes
# in OS and python versions than just statically defining the artifact name.
gh run download $RUN_ID --dir sdists --pattern "Source*"
cp "$(find sdists -name '*.tar.gz' -print -quit)" artifacts/

- name: Create Github release
run: |
# Copy the history notes for this version into the release message
Expand Down
Loading