Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing an artifact name in release automation #1728

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

phargogh
Copy link
Member

@phargogh phargogh commented Jan 6, 2025

I think this was the one issue encountered with the release automation, and this did trigger a rollback which I could manually reconstruct, so it all worked out!

Fixes #1718

Checklist

- [ ] Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
- [ ] Updated the user's guide (if needed)
- [ ] Tested the Workbench UI (if relevant)

Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @phargogh , just jumping in since I saw this. I had a quick question but otherwise happy to approve.

@@ -76,7 +76,7 @@ jobs:
Workbench-macOS-binary \
InVEST-sample-data \
InVEST-user-guide \
"Source distribution"
"Source distribution macos-13 3.12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're just choosing an arbitrary source distribution to check, but choosing not to check both Windows and Mac source distributions? Just want to make sure I understand and then wondering if we should have a note about this being hard coded and that eventually we'll need to update this manually.

Copy link
Member Author

@phargogh phargogh Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% comfortable with hardcoding this, but yes, we need to pick one of the source distributions and python versions to upload here. We're not checking or testing anything, though, just downloading one of the .tar.gz artifacts so we can upload it to the github release object in the next step.

Having said that, I dislike having a statically-defined string here that will need to be updated in the future, so I've fixed it in e5a3065

@phargogh
Copy link
Member Author

phargogh commented Jan 9, 2025

Thanks @dcdenu4! I think I've addressed your concern; the steps affected by this PR aren't actually testing anything, they're just downloading artifacts so that they can be uploaded to the github release object and pypi.

@phargogh phargogh requested a review from dcdenu4 January 9, 2025 21:56
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @phargogh for taking the time to make this change!

@dcdenu4 dcdenu4 merged commit 4af6cd2 into natcap:main Jan 10, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do the InVEST 3.14.3 release
2 participants