-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing an artifact name in release automation #1728
Fixing an artifact name in release automation #1728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @phargogh , just jumping in since I saw this. I had a quick question but otherwise happy to approve.
.github/workflows/release-part-2.yml
Outdated
@@ -76,7 +76,7 @@ jobs: | |||
Workbench-macOS-binary \ | |||
InVEST-sample-data \ | |||
InVEST-user-guide \ | |||
"Source distribution" | |||
"Source distribution macos-13 3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we're just choosing an arbitrary source distribution to check, but choosing not to check both Windows and Mac source distributions? Just want to make sure I understand and then wondering if we should have a note about this being hard coded and that eventually we'll need to update this manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% comfortable with hardcoding this, but yes, we need to pick one of the source distributions and python versions to upload here. We're not checking or testing anything, though, just downloading one of the .tar.gz
artifacts so we can upload it to the github release object in the next step.
Having said that, I dislike having a statically-defined string here that will need to be updated in the future, so I've fixed it in e5a3065
Thanks @dcdenu4! I think I've addressed your concern; the steps affected by this PR aren't actually testing anything, they're just downloading artifacts so that they can be uploaded to the github release object and pypi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @phargogh for taking the time to make this change!
I think this was the one issue encountered with the release automation, and this did trigger a rollback which I could manually reconstruct, so it all worked out!
Fixes #1718
Checklist
- [ ] Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)- [ ] Updated the user's guide (if needed)- [ ] Tested the Workbench UI (if relevant)