Skip to content
This repository was archived by the owner on Nov 16, 2018. It is now read-only.

Add amsru2 seaice tb layers #237

Merged
merged 5 commits into from
Aug 21, 2018
Merged

Conversation

minniewong
Copy link
Contributor

Description

Fixes nasa-gibs/worldview#1178 .

[Description of the bug or feature]

Added 4 AMSRU2 layers - Sea Ice Brightness Temperature 89V and 89H, Sea Ice Concentration 12km and 25km

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if appropriate)
  • I have added tests that prove my fix is effective or that my feature works
  • Lint and unit tests pass locally with my changes (npm run test)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, start a discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@nasa-gibs/worldview

@minniewong minniewong requested a review from ZachTRice August 21, 2018 15:51
@ghost ghost assigned minniewong Aug 21, 2018
@ghost ghost added the under development label Aug 21, 2018
"AMSRU2_Sea_Ice_Concentration_12km": {
"id": "AMSRU2_Sea_Ice_Concentration_12km",
"title": "Sea Ice Concentration (12 km)",
"subtitle": "GCOM-W1 / AMSR2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these subtitles be "AMSRU2" instead of "AMSR2"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - it's confusing, but correct.

@minniewong minniewong merged commit 4282919 into develop Aug 21, 2018
@minniewong minniewong deleted the add-amsru2-seaice-Tb-layers branch August 21, 2018 16:05
@ghost ghost removed the under development label Aug 21, 2018
@ZachTRice ZachTRice mentioned this pull request Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants