Getting the MinSizeRel build working for the ESP32 #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MatthiasJentsch, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
…l (see #777) Signed-off-by: Matthias Jentsch <[email protected]>
AdrianSoundy
approved these changes
Jun 30, 2018
josesimoes
added
Type: enhancement
Area: Config-and-Build
Series: ESP32
josesimoes
reviewed
Jul 16, 2018
| @@ -126,7 +126,8 @@ HRESULT Library_win_dev_adc_native_Windows_Devices_Adc_AdcController::NativeIsCh | |||
| int mode = stack.Arg1().NumericByRef().s4; | |||
|
|
|||
| // Only support Single ended mode for now | |||
| stack.SetResult_Boolean( (mode == (int)AdcChannelMode::SingleEnded) ) ; | |||
| AdcChannelMode singleEndedMode = SingleEnded; | |||
| stack.SetResult_Boolean( (mode == (int)singleEndedMode) ) ; | |||
There was a problem hiding this comment.
@MatthiasJentsch and @AdrianSoundy please keep the PR's atomic.
These changes in the ADC (despite perfectly valid for sure) are completely hidden and unrelated with the PR title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the make file to get the MinSizeRel build working for the ESP32 target
Motivation and Context
How Has This Been Tested?
It's compiling on my machine with the configuration MinSizeRel
Types of changes
Checklist:
Signed-off-by: Matthias Jentsch [email protected]