Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change build configuration of develop branch to MinSizeRel #777

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Change build configuration of develop branch to MinSizeRel #777

merged 1 commit into from
Jun 29, 2018

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jun 28, 2018 •
edited
Loading

Description

Motivation and Context

  • Need to override the configuration for ESP32 in develop branch to get a successful build.

🚧 ESP32 needs to be fixed to take default configuration for this branch 🚧

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Change build configuration of develop branch to MinSizeRel
2ab2216 
*** WIP for ESP32***
had to override build type to debug otherwise build breaks

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Area: Config-and-Build Series: ESP32 Everything related specifically with ESP32 series targets labels Jun 28, 2018
@nfbot
Copy link
Member

nfbot commented Jun 28, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes mentioned this pull request Jun 28, 2018
Closed
2 tasks
@josesimoes josesimoes removed the Series: ESP32 Everything related specifically with ESP32 series targets label Jun 28, 2018
@josesimoes josesimoes merged commit 1dfc180 into nanoframework:develop Jun 29, 2018
@josesimoes josesimoes deleted the work-appveyor branch June 29, 2018 00:13
AdrianSoundy pushed a commit that referenced this pull request Jun 30, 2018
@MatthiasJentsch @AdrianSoundy
Getting the MinSizeRel build working for the ESP32 (#782)
b841577 
* Getting the MinSizeRel build working for the ESP32

* Revert changes in the override configuration for ESP32 in appveyor.yml (see #777)

Signed-off-by: Matthias Jentsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Config-and-Build Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot