Improvements in convert and format handling #1938

edleno2 · 2021-05-31T06:49:04Z

Description

Added FormatException and code to report formatting errors in Parse routines, Updated versions and interop structure.
Replace some current exceptions with FormatException to be consistent with .net core.
Replaced some other generic exceptions with ArgumentOutOfRangeException to be consistent with .net core.
Some cleanup/code-style of lists in exceptions header file.
Fixed handling of signed and unsigned Parse strings - allowed "-0" for example. Refactored some code to allow this.
Added errno processing for integers to catch formatting errors from native math functions.
Corrected min/max check logic for integer and float logic.
Correctly handle (.net core compliant) empty strings and/or space preceding string values about to be parsed.
Report cast errors as invalid cast - .net core compliant.

Motivation and Context

Fixes UnitTestParseTests.box_unbox_Test_1 fails Home#708

How Has This Been Tested?

Ran unit tests on Win32 with both SUPPORT_ANY_BASE_CONVERSION and without that, then ESP32-WROOM and STM32F429I-Discovery.

Screenshots

Types of changes

Improvement (non-breaking change that improves a feature, code or algorithm)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Config and build (change in the configuration and build system, has no impact on code or features)
Dependencies (update dependencies and changes associated, has no impact on code or features)
Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Removed call to GetIntegerPart since it couldn't support UInt64 conversions and edit for invalid values. Wrote new string parse loop based on code that is being used for SUPPORT_ANY_BASE_CONVERSION. Moved some code so it could be used by both SUPPORT_ANY... and the radix 10/16 logic. Possible problem change in Double parsing - used pow() method to better generate the IEEE 574 compliant double in storage. pow() is considered to be slow, but without a more precise float multiplication the resulting double will not match what is used by the Roslyn compiler when creating and comparing doubles. Fixes #715

…nto develop

Cleaned up brackets in system convert to be consistent with rest of file. Added "signed" to char for cast operation - win32 treats char as signed, but gcc does not. Adding signed makes this un-ambiguous. Fix #715

Automated fixes for code style.

…c0f-9575-4847-8842-0c97899413f7 Code style fixes for nanoframework/nf-interpreter PR#1928

Unit tests of boxing/unboxing are expecting invalid cast exception. Code was returning generic System.Exception with HR of CLR_E_WRONG_TYPE. Changed code since invalid cast exception is more descriptive of the problem.

…nto develop

This reverts commit c29ea88.

Add a FormatException and edits for formatting of int and doubles. Fix #708

…nto develop

Win32 builds worked, but not ESP32 and STM32. Fixed (1) missing API in target cmake-variants.json; (2) moved location of <cerrno> declaration to allow it to be defined before redefines happen for "errno". Fix #708

Some code was simplified by combing the handling of both positive and negative results into one routine that checked for adjusting the sign at the end just before returning a value. Remove the code that was commented out now that all unit testing is complete. Fix #708

Removed call to GetIntegerPart since it couldn't support UInt64 conversions and edit for invalid values. Wrote new string parse loop based on code that is being used for SUPPORT_ANY_BASE_CONVERSION. Moved some code so it could be used by both SUPPORT_ANY... and the radix 10/16 logic. Possible problem change in Double parsing - used pow() method to better generate the IEEE 574 compliant double in storage. pow() is considered to be slow, but without a more precise float multiplication the resulting double will not match what is used by the Roslyn compiler when creating and comparing doubles. Fixes #715

Unit tests of boxing/unboxing are expecting invalid cast exception. Code was returning generic System.Exception with HR of CLR_E_WRONG_TYPE. Changed code since invalid cast exception is more descriptive of the problem.

Automated fixes for code style.

This reverts commit c29ea88.

Add a FormatException and edits for formatting of int and doubles. Fix #708

Win32 builds worked, but not ESP32 and STM32. Fixed (1) missing API in target cmake-variants.json; (2) moved location of <cerrno> declaration to allow it to be defined before redefines happen for "errno". Fix #708

Some code was simplified by combing the handling of both positive and negative results into one routine that checked for adjusting the sign at the end just before returning a value. Remove the code that was commented out now that all unit testing is complete. Fix #708

Fix #708

When compiled with devices that use LWIP for networking certain stdlib routines are required to be reentrant. Cleaned up a little left over formatting in nf_errors_exceptions.h Fix #708

Automated fixes for code style.

nfbot · 2021-05-31T06:51:15Z

@edleno2 there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click https://github.com/edleno2/nf-interpreter/pull/6, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…02b-9a25-4604-bbc0-010311b101e3 Code style fixes for nanoframework/nf-interpreter PR#1938

src/CLR/CorLib/corlib_native_System_Convert.cpp

edleno2 · 2021-05-31T07:06:40Z

src/CLR/Core/CLR_RT_HeapBlock.cpp

@@ -893,7 +893,7 @@ HRESULT CLR_RT_HeapBlock::PerformUnboxing(const CLR_RT_TypeDef_Instance &cls)

    if (this->DataType() != DATATYPE_OBJECT)
    {
-        NANOCLR_SET_AND_LEAVE(CLR_E_WRONG_TYPE);


I believe these to be safe changes - the CLR_E_WRONG_TYPE returns a generic Exception type, so any try/catch in C# code will work the same. I could not find any instances of CPP code specifically looking for CLR_E_WRONG_TYPE - everything I could find was just setting the value.

OK. Let's take those. If any changes are required in generics, I'll deal with those.

src/CLR/Include/nf_errors_exceptions.h

josesimoes

Awesome!!

Automated fixes for code style.

nfbot · 2021-05-31T07:42:05Z

@edleno2 there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click https://github.com/edleno2/nf-interpreter/pull/7, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…11c-95bf-4d84-9de8-8fa8f2275231 Code style fixes for nanoframework/nf-interpreter PR#1938

edleno2 and others added 30 commits May 19, 2021 15:22

Merge branch 'develop' of https://github.com/edleno2/nf-interpreter i…

a8de032

…nto develop

Fixes for failing units tests

c574697

Cleaned up brackets in system convert to be consistent with rest of file. Added "signed" to char for cast operation - win32 treats char as signed, but gcc does not. Adding signed makes this un-ambiguous. Fix #715

Merge branch 'nanoframework:develop' into develop

44e29f6

Code style fixes

faaf7b7

Automated fixes for code style.

Merge pull request #1 from nanoframework/nfbot/clang-format-fix/a8ad7…

2ac8c41

…c0f-9575-4847-8842-0c97899413f7 Code style fixes for nanoframework/nf-interpreter PR#1928

Use invalid cast exception for bad casts

c29ea88

Unit tests of boxing/unboxing are expecting invalid cast exception. Code was returning generic System.Exception with HR of CLR_E_WRONG_TYPE. Changed code since invalid cast exception is more descriptive of the problem.

Merge branch 'develop' of https://github.com/edleno2/nf-interpreter i…

5bc49c9

…nto develop

Resolved conflicts with nfbot code style

c89a6d8

Revert "Use invalid cast exception for bad casts"

63ce22c

This reverts commit c29ea88.

Merge branch 'nanoframework:develop' into develop

d909094

Merge branch 'nanoframework:develop' into develop

3828e31

Fix unit test problems with CorLibrary

0032eee

Add a FormatException and edits for formatting of int and doubles. Fix #708

Merge branch 'develop' of https://github.com/edleno2/nf-interpreter i…

f3857e9

…nto develop

Fix building for ESP32 and STM32

079319a

Win32 builds worked, but not ESP32 and STM32. Fixed (1) missing API in target cmake-variants.json; (2) moved location of <cerrno> declaration to allow it to be defined before redefines happen for "errno". Fix #708

Use invalid cast exception for bad casts

6a341e3

Unit tests of boxing/unboxing are expecting invalid cast exception. Code was returning generic System.Exception with HR of CLR_E_WRONG_TYPE. Changed code since invalid cast exception is more descriptive of the problem.

Code style fixes

ff39d1d

Automated fixes for code style.

Revert "Use invalid cast exception for bad casts"

9c064b0

This reverts commit c29ea88.

Fix unit test problems with CorLibrary

d74de4c

Add a FormatException and edits for formatting of int and doubles. Fix #708

Fix building for ESP32 and STM32

8b0461f

Win32 builds worked, but not ESP32 and STM32. Fixed (1) missing API in target cmake-variants.json; (2) moved location of <cerrno> declaration to allow it to be defined before redefines happen for "errno". Fix #708

Fix formatting and code style

0868999

Fix compile issue with errno

5eb739a

update NoReflection checksum for mscorlib

f37abe2

Fix #708

Revert change to cmake-variants.json

9573b54

Undo format changes caused by clang format.

815921f

Merge in changes from pr1936 branch

5b8a6ff

reverted cmake-variants.json change

f16d0bc

edleno2 and others added 2 commits May 29, 2021 19:49

Merge branch 'nanoframework:develop' into develop

4811213

Fix strtoll and strtoull to use reentrant versions when needed

d9afbb2

When compiled with devices that use LWIP for networking certain stdlib routines are required to be reentrant. Cleaned up a little left over formatting in nf_errors_exceptions.h Fix #708

nfbot added Type: enhancement Type: Unit Tests labels May 31, 2021

Code style fixes

02142b7

Automated fixes for code style.

Merge pull request #6 from nanoframework/nfbot/clang-format-fix/f1d44…

8a9e63b

…02b-9a25-4604-bbc0-010311b101e3 Code style fixes for nanoframework/nf-interpreter PR#1938

edleno2 commented May 31, 2021

View reviewed changes

src/CLR/CorLib/corlib_native_System_Convert.cpp Outdated Show resolved Hide resolved

edleno2 commented May 31, 2021

View reviewed changes

src/CLR/CorLib/corlib_native_System_Convert.cpp Outdated Show resolved Hide resolved

edleno2 commented May 31, 2021

View reviewed changes

src/CLR/Include/nf_errors_exceptions.h Show resolved Hide resolved

edleno2 marked this pull request as ready for review May 31, 2021 07:09

Fixes with code style

fa56b84

josesimoes approved these changes May 31, 2021

View reviewed changes

josesimoes removed the Type: Unit Tests label May 31, 2021

Code style fixes

3089f8b

Automated fixes for code style.

Merge pull request #7 from nanoframework/nfbot/clang-format-fix/d0a81…

7f6a70c

…11c-95bf-4d84-9de8-8fa8f2275231 Code style fixes for nanoframework/nf-interpreter PR#1938

josesimoes enabled auto-merge (squash) May 31, 2021 07:55

josesimoes merged commit c14ec56 into nanoframework:develop May 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvements in convert and format handling #1938

Improvements in convert and format handling #1938

edleno2 commented May 31, 2021 •

edited by josesimoes

Loading

nfbot commented May 31, 2021

edleno2 May 31, 2021

josesimoes May 31, 2021

josesimoes left a comment

nfbot commented May 31, 2021

Improvements in convert and format handling #1938

Improvements in convert and format handling #1938

Conversation

edleno2 commented May 31, 2021 • edited by josesimoes Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

Checklist:

nfbot commented May 31, 2021

edleno2 May 31, 2021

Choose a reason for hiding this comment

josesimoes May 31, 2021

Choose a reason for hiding this comment

josesimoes left a comment

Choose a reason for hiding this comment

nfbot commented May 31, 2021

edleno2 commented May 31, 2021 •

edited by josesimoes

Loading