Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update board.h #708

Merged
merged 2 commits into from
May 30, 2018
Merged

Update board.h #708

merged 2 commits into from
May 30, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 27, 2018 •
edited by josesimoes
Loading

Description

  • Enable I2C1 pins on Arduino header

Motivation and Context

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Update board.h
b61e94b 
Enable I2C1 pins on Arduino header
@nfbot
Copy link
Member

nfbot commented May 27, 2018

Hi @MikroBusNet,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@ghost ghost added Type: bug Status: under review Series: STM32xx Everything related specifically with STM32 targets labels May 27, 2018
@piwi1263
Copy link
Member

Wow, 16 Meg of RAM avail that's a lot ...
image

Although this is the I2C version that generates extra read frames on the displays, the spikes are not showing. The color values for RGB are displayed of course.
image

LGTM.

piwi1263
piwi1263 approved these changes May 27, 2018
View reviewed changes
Copy link
Member

@piwi1263 piwi1263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit f431c2b into develop May 30, 2018
@josesimoes josesimoes deleted the MikroBusNet-I2C1F769 branch May 30, 2018 11:47
nfbot pushed a commit that referenced this pull request May 29, 2021
@edleno2 @josesimoes
Fix unit test problems with CorLibrary
d74de4c 
Add a FormatException and edits for formatting of int and doubles.

Fix #708
nfbot pushed a commit that referenced this pull request May 29, 2021
@edleno2 @josesimoes
Fix building for ESP32 and STM32
8b0461f 
Win32 builds worked, but not ESP32 and STM32.  Fixed (1) missing API in target cmake-variants.json; (2) moved location of <cerrno> declaration to allow it to be defined before redefines happen for "errno".

Fix #708
nfbot pushed a commit that referenced this pull request May 29, 2021
@edleno2 @josesimoes
Removed code that was commented out in refactoring
ed43b30 
Some code was simplified by combing the handling of both positive and negative results into one routine that checked for adjusting the sign at the end just before returning a value.  Remove the code that was commented out now that all unit testing is complete.

Fix #708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No I²C pins exposed on F769 reference board
3 participants
@nfbot @piwi1263 @josesimoes