Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependency to rexml #87

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

toshia
Copy link
Contributor

@toshia toshia commented Dec 26, 2020

ruby-dbus make crash on load in ruby 3.0.0 .

/home/toshi/Project/mikutter/vendor/bundle/mikutter-cli/ruby/3.0.0/gems/ruby-dbus-0.16.0/lib/dbus/xml.rb:13:in `require': cannot load such file -- rexml/document (LoadError)
        from /home/toshi/Project/mikutter/vendor/bundle/mikutter-cli/ruby/3.0.0/gems/ruby-dbus-0.16.0/lib/dbus/xml.rb:13:in `<top (required)>'

In ruby 3, rexml becomes bundled gem.
I think ruby-dbus should make dependency to 'rexml'.

see: rails/rails#40281

@coveralls
Copy link

coveralls commented Dec 26, 2020

Coverage Status

Coverage increased (+0.08%) to 88.311% when pulling 6103894 on toshia:add-dependency-rexml into b61c2c4 on mvidner:master.

@voxik
Copy link
Contributor

voxik commented Jan 8, 2021

Actually, I wonder if it was not better to drop the REXML dependency altogether given that Nokogiri have been already supported:

@backend = if AbstractXML.have_nokogiri?
NokogiriParser
else
REXMLParser
end

@na-sa-do
Copy link

@mvidner Please consider this PR. The gem is currently unusable on Ruby 3.

@felipec
Copy link

felipec commented Feb 4, 2022

Actually, I wonder if it was not better to drop the REXML dependency altogether given that Nokogiri have been already supported:

Nokogiri would also be another dependency.

There's no need burden this request with other potential changes.

Just add the rexml dependency now, and consider moving to nokogiri later.

@mvidner
Copy link
Owner

mvidner commented Feb 8, 2022

Actually, I wonder if it was not better to drop the REXML dependency altogether given that Nokogiri have been already supported

Comparing the gem sizes gives me a reason to not make nokogiri mandatory:

rexml: 3.2.5 - April 05, 2021 (91 KB)
nokogiri: 1.13.1 - January 13, 2022 (9.15 MB)

@mvidner
Copy link
Owner

mvidner commented Feb 8, 2022

Thank you!

@mvidner mvidner merged commit 7b1d8c1 into mvidner:master Feb 8, 2022
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 24, 2022
https://build.opensuse.org/request/show/963982
by user mvidner + dimstar_suse
(Fix previous submissions by using the gem file from rubygems.org)

- 0.18.0.beta1
 API:
 * D-Bus structs have been passed as Ruby arrays. Now these arrays
   are frozen.
 * Ruby structs can be used as D-Bus structs.
 Bug fixes:
 * Returning the value for o.fd.DBus.Properties.Get, use the
   specific property signature, not the generic Variant
   (gh#mvidner/ruby-dbus#97).
- 0.17.0
 API:
 * Export properties with `dbus_attr_accessor`, `dbus_reader` etc.
   (gh#mvidner/ruby-dbus#86).
 Bug fixes:
 * Depend on rexml which is separate since Ruby 3.0
   (gh#mvidner/ruby-dbus#87, by Toshiaki Asai).
   Nokogiri is faster but bigger so it remains optional.
 * Fix connection in case ~/.dbus-keyrings has multiple cookies, showing
   as "Oops: undefined method `zero?' for nil:NilClass".
 * Add the mis
felipec added a commit to felipec/xfce-config-helper that referenced this pull request Jul 27, 2022
Fixed now (mvidner/ruby-dbus#87).

Signed-off-by: Felipe Contreras <[email protected]>
@voxik voxik mentioned this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants