-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dependency to rexml #87
Conversation
Actually, I wonder if it was not better to drop the REXML dependency altogether given that Nokogiri have been already supported: Lines 95 to 99 in b61c2c4
|
@mvidner Please consider this PR. The gem is currently unusable on Ruby 3. |
Nokogiri would also be another dependency. There's no need burden this request with other potential changes. Just add the rexml dependency now, and consider moving to nokogiri later. |
Thank you! |
https://build.opensuse.org/request/show/963982 by user mvidner + dimstar_suse (Fix previous submissions by using the gem file from rubygems.org) - 0.18.0.beta1 API: * D-Bus structs have been passed as Ruby arrays. Now these arrays are frozen. * Ruby structs can be used as D-Bus structs. Bug fixes: * Returning the value for o.fd.DBus.Properties.Get, use the specific property signature, not the generic Variant (gh#mvidner/ruby-dbus#97). - 0.17.0 API: * Export properties with `dbus_attr_accessor`, `dbus_reader` etc. (gh#mvidner/ruby-dbus#86). Bug fixes: * Depend on rexml which is separate since Ruby 3.0 (gh#mvidner/ruby-dbus#87, by Toshiaki Asai). Nokogiri is faster but bigger so it remains optional. * Fix connection in case ~/.dbus-keyrings has multiple cookies, showing as "Oops: undefined method `zero?' for nil:NilClass". * Add the mis
Fixed now (mvidner/ruby-dbus#87). Signed-off-by: Felipe Contreras <[email protected]>
ruby-dbus make crash on load in ruby 3.0.0 .
In ruby 3, rexml becomes bundled gem.
I think ruby-dbus should make dependency to 'rexml'.
see: rails/rails#40281