-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service side properties #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
commented
Nov 13, 2020
Thanks, LGTM so far. |
11bf7e0
to
cdd60cb
Compare
jreidinger
reviewed
Feb 8, 2022
jreidinger
reviewed
Feb 8, 2022
@@ -70,7 +70,7 @@ def test_loop_quit(delay) | |||
@obj.on_signal "LongTaskEnd" | |||
end | |||
|
|||
it "tests loop quit" do | |||
it "tests loop quit", slow: true do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
still broken, WIP
To run tests excluding the slow ones: ./spec/tools/test_env rspec -t ~slow ./spec/*_spec.rb
… (except for GetAll)
cdd60cb
to
cf9731e
Compare
```sh rake doc:examples bundle exec examples/doc/exporting_properties.rb ```
Avoids triggering indentation RuboCop.
Coverage check fails because the new CI misses the code covered by the asynchronously started service and counts only the code run directly by RSpec. Locally it works :-/ |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Mar 24, 2022
https://build.opensuse.org/request/show/963982 by user mvidner + dimstar_suse (Fix previous submissions by using the gem file from rubygems.org) - 0.18.0.beta1 API: * D-Bus structs have been passed as Ruby arrays. Now these arrays are frozen. * Ruby structs can be used as D-Bus structs. Bug fixes: * Returning the value for o.fd.DBus.Properties.Get, use the specific property signature, not the generic Variant (gh#mvidner/ruby-dbus#97). - 0.17.0 API: * Export properties with `dbus_attr_accessor`, `dbus_reader` etc. (gh#mvidner/ruby-dbus#86). Bug fixes: * Depend on rexml which is separate since Ruby 3.0 (gh#mvidner/ruby-dbus#87, by Toshiaki Asai). Nokogiri is faster but bigger so it remains optional. * Fix connection in case ~/.dbus-keyrings has multiple cookies, showing as "Oops: undefined method `zero?' for nil:NilClass". * Add the mis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until https://www.rubydoc.info/gems/ruby-dbus renders it, see Reference.md and the API comments in DBus::Object
Example
(
rake doc:examples; cat examples/doc/exporting_properties.rb
)Tests
rake spec
rake osc:build
on Tumbleweed (local problems with non-matching abuild user? edit /etc/passwd and chown home!)Documentation
doc/
files to update them regarding propertiesexample/
work