history updates, add albedos #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* datm will remain nemsdatm until cdeps is added so revert change to srcMaskValue for compatm = "datm"
…on type is specified (NOAA-EMC#41) * switch to using unityone normalization in ufs for all fields * add model abort if more than one normalization type is specified for a single n1:n2:maptype
### Description of changes Correct the accumulation of budget diagnostics ### Specific notes Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are changes expected to change answers? - [X] bit for bit - [ ] different at roundoff level - [ ] more substantial Any User Interface Changes (namelist or namelist defaults changes)? - [ ] Yes - [X] No Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required): - [X] (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py - machines: cheyenne / intel - details (e.g. failed tests): - [X] (recommended) CESM testlist_drv.xml - machines and compilers: cheyenne / intel - details (e.g. failed tests): - [ ] (optional) CESM prealpha test - machines and compilers - details (e.g. failed tests): - [ ] (other) please described in detail - machines and compilers - details (e.g. failed tests): Testing performed if application target is UFS-coupled: - [ ] (recommended) UFS-coupled testing - description: - details (e.g. failed tests): Testing performed if application target is UFS-HAFS: - [ ] (recommended) UFS-HAFS testing - description: - details (e.g. failed tests): Hashes used for testing: - [X] CESM: - repository to check out: https://github.com/ESCOMP/CESM.git - branch: master - hash: 9426f3a0 - [ ] UFS-coupled, then umbrella repostiory to check out and associated hash: - repository to check out: - branch: - hash: - [ ] UFS-HAFS, then umbrella repostiory to check out and associated hash: - repository to check out: - branch: - hash:
* set srcmask to 0 for atm_name=datm
### Description of changes Create a diags.log file with the budget calculation results, this is moved from med.log ### Specific notes Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are changes expected to change answers? - [X] bit for bit - [ ] different at roundoff level - [ ] more substantial Any User Interface Changes (namelist or namelist defaults changes)? - [ ] Yes - [X] No Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required): - [X] (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py - machines: cheyenne / intel - details (e.g. failed tests): - [ ] (recommended) CESM testlist_drv.xml - machines and compilers: - details (e.g. failed tests): - [ ] (optional) CESM prealpha test - machines and compilers - details (e.g. failed tests): - [ ] (other) please described in detail - machines and compilers - details (e.g. failed tests): Testing performed if application target is UFS-coupled: - [ ] (recommended) UFS-coupled testing - description: - details (e.g. failed tests): Testing performed if application target is UFS-HAFS: - [ ] (recommended) UFS-HAFS testing - description: - details (e.g. failed tests): Hashes used for testing: - [ ] CESM: - repository to check out: https://github.com/ESCOMP/CESM.git - branch: master - hash:6ad08bd464 - [ ] UFS-coupled, then umbrella repostiory to check out and associated hash: - repository to check out: - branch: - hash: - [ ] UFS-HAFS, then umbrella repostiory to check out and associated hash: - repository to check out: - branch: - hash:
fixes to land ice runoff in budget table ### Specific notes This PR does not affect any UFS configuration, since the UFS does not use the budget tables at this point. CMEPS Issues Fixed: Fixes ESCOMP#179 Are changes expected to change answers? - [x] bit for bit Any User Interface Changes (namelist or namelist defaults changes)? - [ ] Yes - [x] No Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required): Ran a B1850 f19_g17 case for 3 months and verified that the budget table looked correct with this term Hashes used for testing: - [x] CESM: - repository to check out: https://github.com/ESCOMP/CESM.git - branch: master - tag: cesm2_3_beta02
update to use annotated tags and cmeps prefix Committing to test versioning. dryrun is true so this should not actually create a tag. actionfix:minor:
…pdate ### Description of changes Changes to actually send 2 ice sheets from CISM ### Specific notes Verified that sending two identical ice sheets from CISM to the mediator had the mediator recognize them as separate but identical. This was with a TG compset. Contributors other than yourself, if any: CMEPS Issues Fixed: None Are changes expected to change answers? - [x] bit for bit - [ ] different at roundoff level - [ ] more substantial Any User Interface Changes (namelist or namelist defaults changes)? - [ ] Yes - [x] No Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required): aux_cism test suite was run with nuopc with this change and was successful. Hashes used for testing: - [x] CISM checkout using externals - repository to check out: https://github.com/escomp/cism-wrapper - tag: cismwrap_2_1_81
### Description of changes Fixes ESCOMP#188 where budgets are not written out for December or annually for a 1 year run ### Specific notes The fix is to use nexttime rather than currtime to trigger budget output. This is consistent with the time stamp of history and restart files as well in cmeps. Contributors other than yourself, if any: None Fixes: ESCOMP#188 Are changes expected to change answers? - [x] bit for bit - [ ] different at roundoff level - [ ] more substantial Any User Interface Changes (namelist or namelist defaults changes)? - [ ] Yes - [x] No Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required): This only effects CESM configurations. - Verified that an A compset at f19_g17 run for a year with budgets turned on produced both annual budget information as well as a budget entry for month 12. - Verified that for a 3 month run, B1850 at f19_g17, budgets were created for month 3 and that the results were bfb with a run without these cmeps changes. Hashes used for testing: - [x] CESM: - repository to check out: https://github.com/ESCOMP/CESM.git - tag: cesm2_3_beta02
### Description of changes Add code to buildexe script to check that ESMF VERSION is new enough. ESMF 8.1 is required unless ESMF_AWARE_THREADING is enabled which requires 8.2.0 ### Specific notes Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are changes expected to change answers? - [X] bit for bit - [ ] different at roundoff level - [ ] more substantial Any User Interface Changes (namelist or namelist defaults changes)? - [ ] Yes - [X] No Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required): - [X] (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py - machines: cheyenne intel (all pass) - details (e.g. failed tests): - [ ] (recommended) CESM testlist_drv.xml - machines and compilers: - details (e.g. failed tests): - [ ] (optional) CESM prealpha test - machines and compilers - details (e.g. failed tests): - [ ] (other) please described in detail - machines and compilers - details (e.g. failed tests): Testing performed if application target is UFS-coupled: - [ ] (recommended) UFS-coupled testing - description: - details (e.g. failed tests): Testing performed if application target is UFS-HAFS: - [ ] (recommended) UFS-HAFS testing - description: - details (e.g. failed tests): Hashes used for testing: - [ ] CESM: - repository to check out: https://github.com/ESCOMP/CESM.git - branch: - hash: - [ ] UFS-coupled, then umbrella repostiory to check out and associated hash: - repository to check out: - branch: - hash: - [ ] UFS-HAFS, then umbrella repostiory to check out and associated hash: - repository to check out: - branch: - hash:
change all shebangs to explicitly use python3
fix unitialized variable in timeInit, remove option ifdays0
* update CMEPS to ESCOMP/master * remove ESMF<8.0 conditionals
…re/history_updates
* append component name and averaging type to history_n and history_option variables * trailing whitespace cleanup
* change history config variables to match code
…e/history_updates
* add albedo fields ice->atm * update to ESCOMP/master * check do_budgets config before initializing diags
…ges (NOAA-EMC#56) Co-authored-by: Daniel Rosen <[email protected]> Co-authored-by: Ufuk Turuncoglu <[email protected]>
|
The albedo changes have gone into emc/develop but I held back the history updates; originally I was going to include but I stopped when I couldn't get the averages working. |
mvertens
pushed a commit
that referenced
this pull request
Jul 7, 2022
Exchange grid updates from Dom 2022/01/30
mvertens
pushed a commit
that referenced
this pull request
Jan 3, 2023
Dev/cmcc cm3 Update to cmeps0.13.81 for CMCC-CM3
mvertens
added a commit
that referenced
this pull request
May 5, 2023
minor fixes for ww3/cice coupling and update of code to cmeps0.14.24.
mvertens
pushed a commit
that referenced
this pull request
May 16, 2023
make history_n integer variables
mvertens
pushed a commit
that referenced
this pull request
Feb 19, 2024
Gust mods suggested changes for cam_dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.