Feature/multiple icesheet update #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeniseWorthen
approved these changes
May 7, 2021
jedwards4b
requested changes
May 7, 2021
| @@ -1694,6 +1694,18 @@ | |||
| </values> | |||
| </entry> | |||
|
|
|||
| <entry id="num_icesheets"> | |||
There was a problem hiding this comment.
I'm wondering if this needs to be here - it seems like it may be better to query the cism model to tell you the number of ice sheets?
| @@ -27,11 +28,12 @@ module esmflds | |||
| 'ice ',& | |||
| 'rof ',& | |||
| 'wav ',& | |||
| 'glc '/) | |||
| 'glc1',& | |||
There was a problem hiding this comment.
Is this a limitation that only allows up to 2 ice sheets? If so it seems like a note to that effect should be added here.
jedwards4b
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changes to actually send 2 ice sheets from CISM
Specific notes
Verified that sending two identical ice sheets from CISM to the mediator had the mediator recognize them as separate but identical. This was with a TG compset.
Contributors other than yourself, if any:
CMEPS Issues Fixed: None
Are changes expected to change answers?
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):
aux_cism test suite was run with nuopc with this change and was successful.
Hashes used for testing: