Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types: fx color and some nodes #30325

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Types: fx color and some nodes #30325

merged 1 commit into from
Jan 14, 2025

Conversation

s-rigaud
Copy link
Contributor

Related issue: #30323

Description

Improve previous typing.

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.53
79.09		 339.53
79.09		 +0 B
+0 B
WebGPU 491.01
136.43		 491.01
136.43		 +0 B
+0 B
WebGPU Nodes 490.47
136.32		 490.47
136.32		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.42
112.15		 465.42
112.15		 +0 B
+0 B
WebGPU 561.58
152.14		 561.58
152.14		 +0 B
+0 B
WebGPU Nodes 516.97
141.71		 516.97
141.71		 +0 B
+0 B

@Mugen87 Mugen87 added this to the r173 milestone Jan 14, 2025
@Mugen87 Mugen87 merged commit accd150 into mrdoob:dev Jan 14, 2025
12 checks passed
@s-rigaud s-rigaud deleted the color-fix-types branch January 22, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r173
Development

Successfully merging this pull request may close these issues.
2 participants
@s-rigaud @Mugen87